Skip to content

Comments

miner: fix goroutine leak#3085

Merged
zzzckck merged 2 commits intobnb-chain:developfrom
ironbeer:fix-miner-goroutine-leak
May 15, 2025
Merged

miner: fix goroutine leak#3085
zzzckck merged 2 commits intobnb-chain:developfrom
ironbeer:fix-miner-goroutine-leak

Conversation

@ironbeer
Copy link
Contributor

Description

Found goroutine leak in mining worker when running private chain.

pprof
pprof

metrics
prometheus

Changes

Notable changes:

  • Changed the close call in core.AsyncReceiptBloomGenerator to defer.

@zzzckck zzzckck changed the base branch from master to develop May 15, 2025 07:31
@zzzckck
Copy link
Collaborator

zzzckck commented May 15, 2025

@ironbeer thank you, could you rebase to latest develop branch?

@zzzckck zzzckck merged commit 75b208c into bnb-chain:develop May 15, 2025
7 checks passed
galaio pushed a commit to galaio/bsc that referenced this pull request May 29, 2025
galaio pushed a commit to galaio/bsc that referenced this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants